- Joined
- May 26, 2009
- Messages
- 1,829
Thanks for your submission
There's a number of issues which are rather glaring:
- Store event response values (summoning unit, triggering unit etc.) into temporary variables if you are going to reference them more than twice this also goes for things like picked unit and calculations
- Dummies should be owned by a dummy player, this is so the scorescreen is not interfered with by the ability
- Your tree filtering is very sub-optimal, look at ho some of the approved resources deal with this in order to get an idea of how to do it efficiently
- Your movement controls affect all Destructo Discs including those owned by an opponent
- You have many location leaks
- Knockback can very easily lead to stuck units, we tend to put in some checks and balances to minimize this happening (we make an exception typically if the nature of the ability opposes it)
- Lacks a configuration
I suggest looking at some of the spell tutorials on the site we have if you haven't already - in particular have a look at the "things that leak" or similar threads, as well as looking at how some of the approved resources were made in terms of configuration, efficiency (particularly in the form of code optimization and workarounds for issues such as dummy owners)
There's a number of issues which are rather glaring:
- Store event response values (summoning unit, triggering unit etc.) into temporary variables if you are going to reference them more than twice this also goes for things like picked unit and calculations
- Dummies should be owned by a dummy player, this is so the scorescreen is not interfered with by the ability
- Your tree filtering is very sub-optimal, look at ho some of the approved resources deal with this in order to get an idea of how to do it efficiently
- Your movement controls affect all Destructo Discs including those owned by an opponent
- You have many location leaks
- Knockback can very easily lead to stuck units, we tend to put in some checks and balances to minimize this happening (we make an exception typically if the nature of the ability opposes it)
- Lacks a configuration
I suggest looking at some of the spell tutorials on the site we have if you haven't already - in particular have a look at the "things that leak" or similar threads, as well as looking at how some of the approved resources were made in terms of configuration, efficiency (particularly in the form of code optimization and workarounds for issues such as dummy owners)