Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.
20:15, 15th Apr 2010
Dr Super Good:
A brief view of your spell has revealed quite a few problems which would prevent it from being approved.
The major problem is with the system AI, it is unresponsive and poor. Melee summons need to be infront of range heroes as they move while ranged ones should be the same level. Secondly this is a spell when the idea should rather have been a system for efficency (maybe a person wants to use it more than once while keeping duplicate code down).
You also lack multi level support, which all spells must have.
As for the code. . .
The JASS version is seriously wrong, leaking handle indexes due to not nulled local handles at the end of the function which still retain a removed object (locations is most noticable). It also uses BJ and GUI like structures which are not acceptable as they do nothing useful (just waste time).
The GUI version is ok as far as I can see, next to the pointless globals.
The JASS version needs a total rewrite while the GUI needs to be improved so the spell provides more useful mechanics.
I seriously advise making a system for this and using a few spells as a demonstration rather than a specific spell.
IcemanBo: Too long time as NeedsFix. Rejected.
20:15, 15th Apr 2010
Dr Super Good:
A brief view of your spell has revealed quite a few problems which would prevent it from being approved.
The major problem is with the system AI, it is unresponsive and poor. Melee summons need to be infront of range heroes as they move while ranged ones should be the same level. Secondly this is a spell when the idea should rather have been a system for efficency (maybe a person wants to use it more than once while keeping duplicate code down).
You also lack multi level support, which all spells must have.
As for the code. . .
The JASS version is seriously wrong, leaking handle indexes due to not nulled local handles at the end of the function which still retain a removed object (locations is most noticable). It also uses BJ and GUI like structures which are not acceptable as they do nothing useful (just waste time).
The GUI version is ok as far as I can see, next to the pointless globals.
The JASS version needs a total rewrite while the GUI needs to be improved so the spell provides more useful mechanics.
I seriously advise making a system for this and using a few spells as a demonstration rather than a specific spell.