Shaman spells 1.2

[Moderator]

01:12, 3rd Jan 2010
TriggerHappy:

Your spells leak, use waits and for the most part are not MUI.

 

[Deuterium]

You added new spells and updated without fixing previous problems... unacceptable...

 

[-Berz-]

Triggering	1/5
Eyecandy	2.5/5
Usefulness	2/5
Total	1.8/5

Well You tried...
Really look into leaks! You leak every single location and special effect.
Also most of the spells aren't MUI at all.
Get rid of the wait dependence.

Really look into leaks

 

[nerovesper]

Please read the spell upload rules!!!

 

[Deuterium]

Yeah that too

 

[Diehard@Azeroth]

cool spells man, didnt look into the coding but nice concepts ^^

 

[Sir_Astral]

Thank you diehard at azeroth , i have treid with call RemoveLocation( udg_"point" ) but then spells are not working properly ... its removing location or something... i got new idea how to use that function but what those leaks can do bad ? Make game lagging ... and how to make spells to be MUI should i put locations and other variables into hashtable or what ?

 

[-Berz-]

Yeah leaks are bad, check this program:LeakCheck It will help you

Waits, waits ate bad and they ruin the MUI effect.
To make it so you can:
Recode it so that you use indexing system or use hashtables. There are plenty of tutorials that can help you.

 

[Diehard@Azeroth]

as for using a hashtable, you can and the good thing with hashtables is you dont need to use variables, maybe except for spell values variables (i tried it myself). starting to sound like a dull progrmamer now... how about this mood now ))))))) yea thats much better and berzerkr dont be so rough on him, his eye candy was good enough ^^

 

[Sir_Astral]

I have changed triggers of Thunder Storm and Shamans Wrath spell , can you tell me if now thunder storm is MUI spell ill do same thing to all other spells....
And i have tried to use

call DestroyGroup( udg_Group ) and
call DestroyGroup( udg_Grouo[indexnuber] )

But then triger cant be enabled .... in one time it needs gruop name but in other case it wants to see index im totaly confused....

 

[Diehard@Azeroth]

lets take this step by step, il fix your leaks first, indexing is a bit confusing, i never used indexing in my life because i used a special system of mine for unit ids which makes it easier, but its really a global system. anyways i dont suggest you use indexing, but a global hashtable, il teach you on how to use it after. Il fix leaks and give it to u ^^ il tell you what leaks are w hat and why in the triggers themselves. There are also other stuff to increase efficiency of spells but im just gonna remove leaks.

 

[Sir_Astral]

Thanks man, you are the guy im looking for all these days .. im wandering like headless fly in the world of triggers i want to know but i cant learn alone , or by looking at someone elses spells its all confusing me ... Thanks again ! here is my mail [email protected] , send me text document with map file , please dont use comments i hate them. xD

 

[Diehard@Azeroth]

i fixed the leaks... man you used periodic events with special effects, made meuse special techniques and u used waits, it was a bit hard to do so, but i hope you learn, its not in txt document, they are comments inside the triggers, look at them. i can help you understand them. i will give you link and you will download file ok: ( i cant use things other than comments because comments show you exact places of leaks etc...)
THIS IS THE LINK: http://www.hiveworkshop.com/forums/pastebin.php?id=1nyp8i

btw check out my fixed music system ) you may like it for yoour maps and itsreally easy to use ^^

 

[Sir_Astral]

Sure i will

 

[-Berz-]

Here fixed one trigger:

• Natures Guardian
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Random integer number between 1 and 100) Less than or equal to 20
    • (Life of (Attacked unit)) Less than or equal to ((Max life of (Attacked unit)) - (0.70 x (Max life of (Attacked unit))))
  • Actions
    • Set shaman = (Attacked unit)
    • Unit - Set life of shaman to ((Life of shaman) + (Real((Level of (Ability being cast) for shaman))))
    • Special Effect - Create a special effect attached to the origin of shaman using Abilities\Spells\Items\AIre\AIreTarget.mdl
    • Special Effect - Destroy (Last created special effect)

See how short can it be by only using simple math formula?

You still leak every point/sfx
Also remove "do nothing" actions, they just slow down the execution.
Still spells aren't MUI. And you can't learn it overnight. the easiest way to make spell MUI is "don't stop trying" once you figure it out, everything will seem so simple.

 

[Sir_Astral]

Nature's Guardian is supposed to heal shaman for 10% of his hp,and chance should be improving each lvl, that is thing im goin to change, i will just add cooldown to that spell.But tnx for commenting it, i have totaly forgot of that spell.

 

[Diehard@Azeroth]

man did you really learn from the comments i put? good )) thought it would be 2 hard for you, cus it was for me before/ ))

ok Shamans Wrath isnt MUI still, butknow that it takes some time bro, i really suggest you use something else, i technique i have and its still used in some JASS, PM me ) its much easier, but you may face alot of criticism frmo many people saying arrays are better. ) NVM... that technique is only used if people use something special in their map, i think u gotta stick to arrays so it can work with everyone ;P that technique il teach you it so you can use it for ur spells or systems in ur map if u want.

ok i checked a spell in your map, Efekti, its a periodic event, meaning it runs every w/e seconds, so it does that action every w/e seconds, meaning it creates the 4 locations of the votra, so you need to remove the locations in that trigger once you dont need them, because else the locations you stored at beginning are being leaked and new locations are overwriting it and leaking even more. Basically know that location variables dont just overwrite eachother like integer or so, same goes to unit groups, or sfx, you need to destroy/remove them after you dont need them ^^

to be honest, im really impressed you learned all of this in just a day, i would have never done that. amazing job ^^

 

[Sir_Astral]

Thanks mate, but i have tried to call remove function in same triger where location is,then it does not want to cast spell,so i placed all removelocation functions to lastest triger...ill try to reorganinse them again.Just to finish downloading wow 10 % left xD

 

[VampireofBlood]

i tried to copy it, but i didnt find the script.
can anyone help me?

 

[Sir_Astral]

What script ? what you cant copy ?Just copy whole folder,if it is not goin to work, than try writing to your trigger editor by looking at mine.