Moderator
M
Moderator
00:35 9th May 2014
BPower:
Leakless and working. Approved. Rated with ~3, because it's a useful resource for some mappers. If you consider to add extra functionality I'll reconsider my rating.
21:35 8th May 2014
Here is your current review.
We're not getting anywhere aslong as the function names remain as they are now.
16:42 21nd Mar 2014
BPower:
http://www.hiveworkshop.com/forums/spells-569/custom-death-v1-04-a-248629/index2.html#post2502389
20:03, 2nd Mar 2014
Magtheridon96:
You would then specify "pseudo-dead" in your required documentation.
Also, space out the functions nicely so the code is easier to read. :v
BPower:
Leakless and working. Approved. Rated with ~3, because it's a useful resource for some mappers. If you consider to add extra functionality I'll reconsider my rating.
21:35 8th May 2014
Here is your current review.
We're not getting anywhere aslong as the function names remain as they are now.
16:42 21nd Mar 2014
BPower:
http://www.hiveworkshop.com/forums/spells-569/custom-death-v1-04-a-248629/index2.html#post2502389
20:03, 2nd Mar 2014
Magtheridon96:
IsUnitDead
is a terribly misleading function name and UnitDie
is a terrible name that makes no sense. I think you should label these deaths as PseudoDead. IsUnitPseudoDead, PseudoKillUnit and PseudoUnkillUnit would be better function names because they insinuate the side effects better.You would then specify "pseudo-dead" in your required documentation.
Also, space out the functions nicely so the code is easier to read. :v